Fix 9 ClangTidyReadability findings:#2373
Merged
jemoreira merged 1 commit intogoogle:mainfrom Apr 10, 2026
Merged
Conversation
Member
jemoreira
commented
Apr 10, 2026
jemoreira
commented
- the 'empty' method should be used to check for emptiness instead of comparing to an empty object.
- do not use 'compare' to test equality of strings; use the string equality operator instead.
- redundant get() call on smart pointer.
- the 'empty' method should be used to check for emptiness instead of 'size'.
* the 'empty' method should be used to check for emptiness instead of comparing to an empty object. * do not use 'compare' to test equality of strings; use the string equality operator instead. * redundant get() call on smart pointer. * the 'empty' method should be used to check for emptiness instead of 'size'.
ser-io
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.