Skip to content

Implicitly add :gtest and :gtest_main dependencies to cf_cc_test targets#2408

Merged
Databean merged 1 commit intogoogle:mainfrom
Databean:always_gtest
Apr 16, 2026
Merged

Implicitly add :gtest and :gtest_main dependencies to cf_cc_test targets#2408
Databean merged 1 commit intogoogle:mainfrom
Databean:always_gtest

Conversation

@Databean
Copy link
Copy Markdown
Member

@Databean Databean commented Apr 15, 2026

Every target includes these dependencies manually, changing it to be implicit adds some convenience to defining new test targets and reduces clutter.

BUILD.bazel file changes were made mechanically by running

~/go/bin/buildozer 'remove deps "@googletest//:gtest"' '//cuttlefish/...:%cf_cc_test'
~/go/bin/buildozer 'remove deps "@googletest//:gtest_main"' '//cuttlefish/...:%cf_cc_test'

Bug: b/503084517

@Databean Databean requested a review from cjreynol April 15, 2026 23:23
@Databean Databean enabled auto-merge April 15, 2026 23:23
Every target includes these dependencies manually, changing it to be
implicit adds some convenience to defining new test targets and reduces
clutter.

BUILD.bazel file changes were made mechanically by running
```
~/go/bin/buildozer 'remove deps "@googletest//:gtest"' '//cuttlefish/...:%cf_cc_test'
~/go/bin/buildozer 'remove deps "@googletest//:gtest_main"' '//cuttlefish/...:%cf_cc_test'
```

Bug: b/503084517
@Databean Databean added this pull request to the merge queue Apr 16, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Apr 16, 2026
@Databean Databean added this pull request to the merge queue Apr 16, 2026
Merged via the queue into google:main with commit 4258958 Apr 16, 2026
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants