Don't store references to cuttlefish::CuttlefishConfig::InstanceSpecific#2543
Open
jemoreira wants to merge 1 commit intogoogle:mainfrom
Open
Don't store references to cuttlefish::CuttlefishConfig::InstanceSpecific#2543jemoreira wants to merge 1 commit intogoogle:mainfrom
jemoreira wants to merge 1 commit intogoogle:mainfrom
Conversation
The instance specific class only holds a pointer to the global config object and its own name, so they are very cheap to copy. This objects are usually created by calling `cuttlefish::CuttlefishConfig::Instances` which creates ephemeral instances of `InstanceSpecific`. Most cases addressed by this PR are "safe" because the `InstanceSpecific` object being referenced is created in run_cvd's main loop which doesn't return and therefore the objects never go out of scope. Other cases were addressed by google#2541.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The instance specific class only holds a pointer to the global config object and its own name, so they are very cheap to copy.
This objects are usually created by calling
cuttlefish::CuttlefishConfig::Instanceswhich creates ephemeral instances ofInstanceSpecific.Most cases addressed by this PR are "safe" because the
InstanceSpecificobject being referenced is created in run_cvd's main loop which doesn't return and therefore the objects never go out of scope. Other cases were addressed by#2541.
Bug: b/511301172