Treat all monitored subprocesses as critical.#2592
Merged
Conversation
If we default monitored subprocesses to being noncritical, then when we do encounter a problem with a critical subprocess that isn't labeled as such, cvd will appear to hang/take forever. Therefore, it is better to assume all subprocesses as critical and be explicit about which ones aren't. Even if we later introduce timeouts to ensure creations never hang forever, it is better that we be proactive and just abend. Bug: 508320217
Databean
approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If we default monitored subprocesses to being noncritical, then when we do encounter a problem with a critical subprocess that isn't labeled as such, cvd will appear to hang/take forever. Therefore, it is better to assume all subprocesses as critical and be explicit about which ones aren't.
Even if we later introduce timeouts to ensure creations never hang forever, it is better that we be proactive and just abend.
Bug: 508320217