Split cvd start into create and start#661
Merged
jemoreira merged 3 commits intogoogle:mainfrom Aug 9, 2024
Merged
Conversation
jemoreira
requested review from
Databean,
adelva1984,
jmacnak,
rmuthiah and
ser-io
as code owners
Databean
reviewed
Aug 8, 2024
base/cvd/cuttlefish/host/commands/cvd/server_command/load_configs.cpp
Outdated
Show resolved
Hide resolved
base/cvd/cuttlefish/host/commands/cvd/server_command/create.cpp
Outdated
Show resolved
Hide resolved
base/cvd/cuttlefish/host/commands/cvd/server_command/create.cpp
Outdated
Show resolved
Hide resolved
base/cvd/cuttlefish/host/commands/cvd/server_command/create.cpp
Outdated
Show resolved
Hide resolved
base/cvd/cuttlefish/host/commands/cvd/server_command/create.cpp
Outdated
Show resolved
Hide resolved
ser-io
requested changes
Aug 8, 2024
base/cvd/cuttlefish/host/commands/cvd/server_command/create.cpp
Outdated
Show resolved
Hide resolved
base/cvd/cuttlefish/host/commands/cvd/server_command/create.cpp
Outdated
Show resolved
Hide resolved
jemoreira
force-pushed
the
main
branch
2 times, most recently
from
9382e2d to
40bc23a
Compare
ser-io
approved these changes
Aug 9, 2024
The remove command attempts to stop devices first based on their state. If the device is not really running stop fails, but remove should still remove the instance from the database.
The commands are - create: Creates the new instance groups, allocates instance ids and its locks under /tmp/acloud_cvd_temp. There is an option to start groups immediately after creation, enabled by default. - start: Starts existing instance groups that are not currently running. These are in addition to the existing stop and remove commands, that are the complements to start and create respectively.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split cvd start functionality into two commands
The commands are
locks under /tmp/acloud_cvd_temp. There is an option to start groups
immediately after creation, enabled by default.