Generated CMake file hardcodes path to librt.so

[pitrou]

The file build/src/CMakeFiles/Export/lib/cmake/benchmark/benchmarkTargets.cmake which is generated when building gbenchmark contains the following code on Linux:

set_target_properties(benchmark::benchmark PROPERTIES
  INTERFACE_INCLUDE_DIRECTORIES "${_IMPORT_PREFIX}/include"
  INTERFACE_LINK_LIBRARIES "-pthread;/usr/lib/x86_64-linux-gnu/librt.so"
)

Instead of hard-coding the path to librt.so it should probably use -lrt. This is causing issues for conda packages (see conda-forge/benchmark-feedstock#5 (comment)).

[dmah42]

as far as i can tell this is coming from https://github.com/google/benchmark/blob/33d440465041fe83b831f537b9646756655806f0/src/CMakeLists.txt#L32 ie, we use find_library from cmake to find rt. Dominic Hamon | Google *There are no bad ideas; only good ideas that go horribly wrong.*

…

On Mon, May 27, 2019 at 2:38 PM Antoine Pitrou ***@***.***> wrote: The file build/src/CMakeFiles/Export/lib/cmake/benchmark/benchmarkTargets.cmake which is generated when building gbenchmark contains the following code on Linux: set_target_properties(benchmark::benchmark PROPERTIES INTERFACE_INCLUDE_DIRECTORIES "${_IMPORT_PREFIX}/include" INTERFACE_LINK_LIBRARIES "-pthread;/usr/lib/x86_64-linux-gnu/librt.so" ) Instead of hard-coding the path to librt.so it should probably use -lrt. This is causing issues for conda packages (see conda-forge/benchmark-feedstock#5 (comment) <conda-forge/benchmark-feedstock#5 (comment)> ). — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#824?email_source=notifications&email_token=AAD4QMQYKRUEHFOJ5JFJT4LPXPP4XA5CNFSM4HP4B4QKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4GWBDIRQ>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAD4QMSZY5LLRSMS6MLQ4VDPXPP4XANCNFSM4HP4B4QA> .

[mingwandroid]

This is something I can probably be useful helping to look into along with the Cmake developers. @pitrou, if you can open something at anaconda-issues I can assign it to myself. Thanks.

[sergiud]

@dominichamon This was fixed in #1244.