Skip to content
This repository was archived by the owner on Jan 10, 2023. It is now read-only.

Re-added support for CocoaPods/Carthage after changing repos. Updated…#1

Merged
vicng merged 1 commit intomasterfrom
vn-1-deps
Feb 9, 2016
Merged

Re-added support for CocoaPods/Carthage after changing repos. Updated…#1
vicng merged 1 commit intomasterfrom
vn-1-deps

Conversation

@vicng
Copy link
Copy Markdown
Contributor

@vicng vicng commented Feb 8, 2016

… Carthage setup to include the Checkouts dir and to ignore the Build dir.

Review on Reviewable

@vicng
Copy link
Copy Markdown
Contributor Author

vicng commented Feb 8, 2016

+@RoboErikG


Review status: 0 of 32 files reviewed at latest revision, all discussions resolved.


Comments from the review on Reviewable.io

@RoboErikG
Copy link
Copy Markdown
Contributor

As discussed, link the Blockly lib against the checked in xml lib so it can build without extra steps. After that LGTM until we find a better way to handle these.


Review status: 0 of 32 files reviewed at latest revision, all discussions resolved.


Comments from the review on Reviewable.io

… Carthage setup to include the Checkouts dir and to ignore the Build dir.
@vicng
Copy link
Copy Markdown
Contributor Author

vicng commented Feb 9, 2016

Done.


Review status: 0 of 32 files reviewed at latest revision, all discussions resolved.


Comments from the review on Reviewable.io

vicng added a commit that referenced this pull request Feb 9, 2016
Re-added support for CocoaPods/Carthage after changing repos. Updated…
@vicng vicng merged commit 44d08bf into master Feb 9, 2016
@vicng vicng deleted the vn-1-deps branch February 9, 2016 00:29
vicng added a commit that referenced this pull request Feb 10, 2016
Re-added support for CocoaPods/Carthage after changing repos. Updated…
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants