refactor: Remove block and workspace drag surfaces#6758
Merged
Conversation
Contributor
|
@gonfunko Are you cool waiting to merge this until after the release next week? or do you want it to go in? Personally I would rather have longer to test it if possible. |
Contributor
Author
Yes, absolutely was not expecting this to land in the imminent release. |
BeksOmega
approved these changes
Jan 11, 2023
Contributor
BeksOmega
left a comment
BeksOmega
left a comment
There was a problem hiding this comment.
Generally LGTM! One nit, and then we need to decide whether this is a breaking change or not.
gonfunko
added
the
breaking change
1 task
4 tasks
maribethb
added a commit
to maribethb/blockly
that referenced
this pull request
Mar 9, 2023
…yPiFoundation#6758)" This reverts commit 332c0fd.
4 tasks
maribethb
added a commit
that referenced
this pull request
Mar 9, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basics
npm run formatandnpm run lintThe details
Resolves
#6160, #781, #5759
Proposed Changes
This PR removes block and workspace drag surfaces in favor of directly translating the relevant SVGs.
Reason for Changes
Performance for both panning the workspace and dragging blocks, particularly when large block stacks are involved, is substantially improved on Chrome, essentially unchanged on Firefox (where it was already excellent) ands slightly reduced on Safari, yet still much better than it was on Chrome before this change.
In addition to generally improved performance, this also removes a good bit of code, improving future maintainability.
Test Coverage
Verified that tests are passing and manually tested in Chrome, Firefox and Safari.