Add libFuzzer target for BrotliDecoderAttachDictionary overflow#1443
Open
0xazanul wants to merge 2 commits intogoogle:masterfrom
Open
Add libFuzzer target for BrotliDecoderAttachDictionary overflow#14430xazanul wants to merge 2 commits intogoogle:masterfrom
0xazanul wants to merge 2 commits intogoogle:masterfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Contributor
Author
|
Is there any update on this one ? |
Contributor
Author
|
Hey just for confirmation the issue i reported is in 1443 not 1438 , can u guys confirm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a libFuzzer target for BrotliDecoderAttachDictionary().
The fuzz target exposes an integer overflow in AttachCompoundDictionary()
(c/dec/decode.c:1545), where a size_t value is truncated to int:
When size > INT_MAX, this results in signed integer overflow and corrupts
addon->total_size.
The corrupted state propagates into
EnsureCompoundDictionaryInitialized(), and under fuzzing leads to
memory corruption and a segmentation fault in
BrotliTransformDictionaryWord().
Reproducibility:
This fuzz target improves test coverage and enables integration
with OSS-Fuzz to detect this issue and similar regressions.