Check that total compound dictionary size does not overflow.#1450
Merged
copybara-service[bot] merged 1 commit intomasterfrom Apr 8, 2026
Merged
Check that total compound dictionary size does not overflow.#1450copybara-service[bot] merged 1 commit intomasterfrom
copybara-service[bot] merged 1 commit intomasterfrom
Conversation
copybara-service
Bot
force-pushed
the
test_896514011
branch
2 times, most recently
from
fd758c0 to
49a1a0c
Compare
copybara-service
Bot
force-pushed
the
test_896514011
branch
from
49a1a0c to
4792c8e
Compare
Contributor
|
Hey just for confirmation the issue i reported is in 1443 not 1438 , can u guys confirm |
Collaborator
Contributor
|
so i reported it earlier to google vrp and they said first i need to get it merged, so does this qualify as this has been merged ? |
Collaborator
|
Yes, I believe so. Could mention that in original PR. |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check that total compound dictionary size does not overflow.
Thanks to @mohammadmseet-hue who reported the problem in #1438 on 29.03.2026
Thanks to @0xazanul who reported the problem in #1443 on 31.03.2026
NB: it is unlikely a security threat; since all the dictionaries are loaded to memory before use, practically that means that their memory ranges do not intersect; moreover brotli codec does not support entities that are 64MiB+ away; consequently total amount of attached dictionaries could never reach 64MiB+ (15 times 64MiB if developer is careless).