Make stdin/stdout work on Windows for tools/bro#311
Closed
fasterthanlime wants to merge 2 commits into
Closed
Conversation
…piles on non-Windows platforms again
Collaborator
|
Very sorry for that big latency (encoder was under construction). Fixed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The code in master works well on Linux/OSX, not so well on Windows. This PR makes it work for all 3 main platforms. Props to #174 for giving helpful hints!
Tested on OSX 10.11.3 with clang 7.0.2, and Windows 10 with msys2, gcc 5.2.0