Skip to content

Make BUILD_SHARED_LIBS default to ON. #326#445

Closed
fred-wang wants to merge 1 commit into
google:masterfrom
fred-wang:default-to-shared-libs
Closed

Make BUILD_SHARED_LIBS default to ON. #326#445
fred-wang wants to merge 1 commit into
google:masterfrom
fred-wang:default-to-shared-libs

Conversation

@fred-wang

Copy link
Copy Markdown
Contributor

@eustas Let's see if that makes the bots happy (maybe we want to change the travis / appveyor files too...)

@googlebot

Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@googlebot

Copy link
Copy Markdown

CLAs look good, thanks!

@eustas

eustas commented Oct 18, 2016

Copy link
Copy Markdown
Collaborator

VS thinks that brotlienc depends on static brotlicommon...
Of course we can modify appveyor config to force building static artefacts, but first we should teach CMake to generate valid shared library build for VS.

@eustas

eustas commented Oct 18, 2016

Copy link
Copy Markdown
Collaborator

Working on DLL imports/exports + stub lib generation. That will include this PR.

@fred-wang

Copy link
Copy Markdown
Contributor Author

Closing as it is included in #450

@fred-wang fred-wang closed this Oct 18, 2016
@fred-wang fred-wang deleted the default-to-shared-libs branch June 5, 2018 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants