decode: fix NEON inclusion#714
Merged
Merged
Conversation
The macro that checks for NEON support should be __ARM_NEON, not
__ARM_NEON__. [1]
AArch64 compilers define __ARM_NEON but not __ARM_NEON__.
AArch32 compilers currently seem to define both, but could be within their
rights to drop __ARM_NEON__ in future versions.
This change moves the check into the common/platform.h file, checks for
both forms, and sets BROTLI_TARGET_NEON if NEON support is available.
[1] Section 6.5.4 of the ARM C Language Extensions.
(At the time of writing, the latest version was Release 2.1.)
stephenkyle-ARM
force-pushed
the
fix-neon-inclusion
branch
from
10a1f1f to
f7a7c49
Compare
|
✅ Build brotli 1.0.0#1376 completed (commit 0c223882e9 by @stephenkyle-ARM) |
|
✅ Build brotli 1.0.0#1377 completed (commit 3147c1cd10 by @stephenkyle-ARM) |
Collaborator
|
Thanks! |
Collaborator
|
In this PR |
Contributor
Author
|
Thanks for doing that @eustas. I was curious why the CI bot I added didn't pick this up, I should have a PR that fixes this shortly... |
juj
pushed a commit
to Unity-Technologies/brotli
that referenced
this pull request
May 13, 2023
The macro that checks for NEON support should be __ARM_NEON, not
__ARM_NEON__. [1]
AArch64 compilers define __ARM_NEON but not __ARM_NEON__.
AArch32 compilers currently seem to define both, but could be within their
rights to drop __ARM_NEON__ in future versions.
This change moves the check into the common/platform.h file, checks for
both forms, and sets BROTLI_TARGET_NEON if NEON support is available.
[1] Section 6.5.4 of the ARM C Language Extensions.
(At the time of writing, the latest version was Release 2.1.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The macro that checks for NEON support should be __ARM_NEON, not
ARM_NEON. [1]
AArch64 compilers define __ARM_NEON but not ARM_NEON.
AArch32 compilers currently seem to define both, but could be within their
rights to drop ARM_NEON in future versions.
This change moves the check into the common/platform.h file, checks for
both forms, and sets BROTLI_TARGET_NEON if NEON support is available.
[1] Section 6.5.4 of the ARM C Language Extensions.
(At the time of writing, the latest version was Release 2.1.)