Skip to content

Conversation

@micahhausler
Copy link
Contributor

Closes #1413

@k8s-bot
Copy link
Collaborator

k8s-bot commented Aug 23, 2016

Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in kubernetes/test-infra/jenkins/job-configs/kubernetes-jenkins-pull instead.)

This message will repeat several times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

@micahhausler
Copy link
Contributor Author

Can someone "ok to test" this?

@timstclair
Copy link
Contributor

ok to test

@timstclair
Copy link
Contributor

Could you set a non-zero-valued inodes free/total in the test container info?

@timstclair timstclair self-assigned this Aug 26, 2016
@k8s-bot
Copy link
Collaborator

k8s-bot commented Aug 26, 2016

Jenkins GCE e2e

Build/test passed for commit 7acd82f.

@micahhausler
Copy link
Contributor Author

@timothysc Updated

@k8s-bot
Copy link
Collaborator

k8s-bot commented Aug 26, 2016

Jenkins GCE e2e

Build/test failed for commit 7ae2384.

@micahhausler
Copy link
Contributor Author

micahhausler commented Aug 26, 2016

@timstclair I think that the test container can't get the inodes of the device. Do you want me to do a check for if fs.HasInodes {} or just zero-out the test data?

@timstclair
Copy link
Contributor

I think you just need to manually add the values here: https://github.com/google/cadvisor/blob/master/metrics/prometheus_test.go#L130

@k8s-bot
Copy link
Collaborator

k8s-bot commented Aug 27, 2016

Jenkins GCE e2e

Build/test failed for commit dd6cc41.

@k8s-bot
Copy link
Collaborator

k8s-bot commented Aug 27, 2016

Jenkins GCE e2e

Build/test passed for commit a9bb292.

@timstclair
Copy link
Contributor

LGTM

@timstclair timstclair merged commit bea0adb into google:master Aug 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants