-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Add inodes to /metrics endpoint #1437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test". This message will repeat several times in short succession due to jenkinsci/ghprb-plugin#292. Sorry. |
|
Can someone "ok to test" this? |
|
ok to test |
|
Could you set a non-zero-valued inodes free/total in the test container info? |
7acd82f to
7ae2384
Compare
|
@timothysc Updated |
|
@timstclair I think that the test container can't get the inodes of the device. Do you want me to do a check for |
|
I think you just need to manually add the values here: https://github.com/google/cadvisor/blob/master/metrics/prometheus_test.go#L130 |
7ae2384 to
dd6cc41
Compare
dd6cc41 to
a9bb292
Compare
|
LGTM |
Closes #1413