Expand the test cases for ParsePosixSpec()#351
Merged
Conversation
Now that google#347 has introduced `time_zone_posix_test`, expand it to cover all of `ParsePosixSpec()`, including success and failure cases. Also: - Update the BNF for `ParsePosixSpec()` after google#347 moved the comma into `datetime`. - Update the Open Group URL for the TZ environment-variable specification.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that #347 has introduced
time_zone_posix_test, expand it to cover all ofParsePosixSpec(), including success and failure cases.Also:
ParsePosixSpec()after Make cctz::ParseDateTime() return NULL on failure #347 moved the comma intodatetime.