Skip to content

Gracefully handle invalid ghost fuzzer configurations #5380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dylanjew merged 2 commits into from
Jul 23, 2026
+16 −5
Merged

Gracefully handle invalid ghost fuzzer configurations #5380

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
99c7038
Gracefully handle invalid ghost fuzzer configurations
dylanjew Jul 23, 2026
f4b7c15
Fix test
dylanjew Jul 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/clusterfuzz/_internal/bot/tasks/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -593,6 +593,9 @@ def preprocess_update_fuzzer_and_data_bundles(
if not fuzzer:
logs.error('No fuzzer exists with name %s.' % fuzzer_name)
raise errors.InvalidFuzzerError
if not fuzzer.blobstore_key:
logs.error(f'Fuzzer {fuzzer_name} does not have a blobstore_key.')
raise errors.InvalidFuzzerError

update_input = uworker_msg_pb2.SetupInput( # pylint: disable=no-member
fuzzer_name=fuzzer_name,
Expand Down
13 changes: 9 additions & 4 deletions src/clusterfuzz/_internal/bot/tasks/utasks/fuzz_task.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
from google.cloud import ndb

from clusterfuzz._internal.base import dates
from clusterfuzz._internal.base import errors
from clusterfuzz._internal.base import utils
from clusterfuzz._internal.bot import testcase_manager
from clusterfuzz._internal.bot.fuzzers import builtin
Expand Down Expand Up @@ -1216,15 +1217,15 @@ def write_crashes_to_big_query(group, newly_created_testcase, existing_testcase,
# Happens in case the big query function is disabled (local development).
return

errors = result.get('insertErrors', [])
failed_count = len(errors)
insert_errors = result.get('insertErrors', [])

@dylanjew dylanjew Jul 23, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

name conflict with the package

failed_count = len(insert_errors)

monitoring_metrics.BIG_QUERY_WRITE_COUNT.increment_by(
row_count - failed_count, {'success': True})
monitoring_metrics.BIG_QUERY_WRITE_COUNT.increment_by(
failed_count, {'success': False})

for error in errors:
for error in insert_errors:
logs.error(
('Ignoring error writing the crash '
f'({group.crashes[error["index"]].crash_type}) to BigQuery.'),
Expand Down Expand Up @@ -2290,7 +2291,11 @@ def utask_preprocess(fuzzer_name, job_type, uworker_env):
# Delay adding the fuzz target to logs context until it is chosen in
# preprocess.
with logs.fuzzer_log_context(fuzzer_name, job_type, fuzz_target=None):
return _utask_preprocess(fuzzer_name, job_type, uworker_env)
try:
return _utask_preprocess(fuzzer_name, job_type, uworker_env)
except errors.InvalidFuzzerError:
logs.error('Fuzzer %s is invalid or no longer exists.' % fuzzer_name)
return None


def save_fuzz_targets(output):
Expand Down
5 changes: 4 additions & 1 deletion src/clusterfuzz/_internal/tests/core/bot/tasks/setup_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,7 +222,10 @@ def setUp(self):
self.fuzzer_name = 'fuzzer'
data_bundle_name = 'data_bundle_name'
data_types.Fuzzer(
name=self.fuzzer_name, data_bundle_name=data_bundle_name).put()
name=self.fuzzer_name,
data_bundle_name=data_bundle_name,
blobstore_key='blobstore_key',
).put()
self.data_bundle = data_types.DataBundle(name=data_bundle_name)
self.data_bundle.put()
data_types.DataBundle(name=data_bundle_name).put()
Expand Down
Loading