Capture user defined errors separately from UNHANDLED_EXCEPTION - #5402
Open
dylanjew wants to merge 1 commit into
Open
Capture user defined errors separately from UNHANDLED_EXCEPTION#5402dylanjew wants to merge 1 commit into
dylanjew wants to merge 1 commit into
Conversation
dylanjew
changed the title
aakallam
approved these changes
Jul 30, 2026
…N in metrics In _MetricRecorder.__exit__, check whether _exc_type inherits from errors.Error or testcase_manager.TestcaseManagerError and record error_condition as _exc_type.__name__ instead of 'UNHANDLED_EXCEPTION'. We alert based on UNHANDLED_EXCEPTION, and these user defined Errors represent exceptional but expected scenariors in Clusterfuzz where the task is not meant to succeed. For example, there is no build for a variant task that we triggered, or the fuzzer is no longer valid. In these cases, we typically want to ACK the task and skip it, but these expected errors make it hard to set up alerts on real issues.
dylanjew
force-pushed
the
dylanj/task-errors-1
branch
from
July 31, 2026 18:14
796e707 to
a805288
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
_MetricRecorder.__exit__, check whether the exception inherits fromerrors.Errorortestcase_manager.TestcaseManagerErrorand record the coresponding error_condition instead of'UNHANDLED_EXCEPTION'.We want to alert based on
UNHANDLED_EXCEPTION, and these user defined Errors represent exceptional but expected scenariors in Clusterfuzz where the task is not meant to succeed. For example, there is no build for a variant task that we triggered, or the fuzzer is no longer valid. In these cases, we typically want to ACK the task and skip it, but these expected errors make it hard to set up alerts on real issues.Here's an example of logs of 2 deleted Testcases going through the Variant task, failing, and getting retried multiple times and triggering an alert due to the postprocess error rate spikes above 20%
Testing
deployed to dev. haven't seen any of these new metrics yet but no errors either.
Related PRs