-
Notifications
You must be signed in to change notification settings - Fork 46
gitlab: improve documentation #113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| The cache directory needs to defined as `CFL_CACHE_DIR` to be used by ClusterFuzzLite. | ||
| If it is not defined, the default value is `cache`. | ||
| You should ensure that the runners share the access to the cache. | ||
| As such, this filestore is not available with sharer runners on Gitlab.com and you |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"sharer"?
It's not available? that's not good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed the typo
As I see the code in cifuzz, only upload_build (and download) imply the use of a cache because GitFilestore does not handle builds (only coverage and corpus)
IIRC, there was some discussion where I pointer that artifacts cannot be used (because they cannot be read from another gitlab pipeline).
Maybe I can try to revisit this, maybe try https://docs.gitlab.com/ee/api/projects.html#upload-a-file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But https://gitlab.com/gitlab-org/gitlab/-/issues/25838 is still open...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Surprisingly, that seems to work on gitlab.com shared runner
Checking cache for clusterfuzz-lite-non_protected...
Downloading cache.zip from https://storage.googleapis.com/gitlab-com-runners-cache/project/39545533/clusterfuzz-lite-non_protected
Gitlab Runners seem to share the cache on some google storage even if that is not a hard guarantee
between Gitlab.com with shared runner and self-managed instances.
87ee37f to
ac253bc
Compare
* gitlab: improve documentation (#113) * gitlab: improve documentation between Gitlab.com with shared runner and self-managed instances. * add a notive about gitlab CI variable "protected" * remove irrelevant assumption about gitlab shared runners abilities * Bump tzinfo from 1.2.9 to 1.2.10 in /docs (#115) Bumps [tzinfo](https://github.com/tzinfo/tzinfo) from 1.2.9 to 1.2.10. - [Release notes](https://github.com/tzinfo/tzinfo/releases) - [Changelog](https://github.com/tzinfo/tzinfo/blob/master/CHANGES.md) - [Commits](tzinfo/tzinfo@v1.2.9...v1.2.10) --- updated-dependencies: - dependency-name: tzinfo dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump nokogiri from 1.12.2 to 1.14.0 in /docs Bumps [nokogiri](https://github.com/sparklemotion/nokogiri) from 1.12.2 to 1.14.0. - [Release notes](https://github.com/sparklemotion/nokogiri/releases) - [Changelog](https://github.com/sparklemotion/nokogiri/blob/main/CHANGELOG.md) - [Commits](sparklemotion/nokogiri@v1.12.2...v1.14.0) --- updated-dependencies: - dependency-name: nokogiri dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Catena cyber <35799796+catenacyber@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
between Gitlab.com with shared runner and self-managed instances.
cc @jonathanmetzman
It seems to work here
https://gitlab.com/catenacyber/suricata/-/merge_requests/1/pipelines