Add android proguard specs#1059
Closed
jaredsburrows wants to merge 2 commits into
Closed
Conversation
Author
|
@ronshapiro This should also close #795. |
Author
|
@ronshapiro @cushon Can I get a review? :) |
|
Lgtm! |
ronshapiro
pushed a commit
that referenced
this pull request
Feb 7, 2018
Closes #1059 Closes #1040 Closes #795 RELNOTES=Add Android proguard specs ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=184691501
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Example test: https://github.com/bazelbuild/bazel/blob/29f2ba82ca7581a68b4cc760d15fc9f89b0ea9b9/src/test/java/com/google/devtools/build/lib/rules/android/AndroidBinaryTest.java#L624
Based on the example test, I set
proguard_specs = ["proguard.cfg"].@ronshapiro Closes #1040