0.17.0 artifacts: apply upgrade-run and review feedback - #2759
Merged
chalin merged 35 commits intoAug 30, 2026
Conversation
chalin
force-pushed
the
chalin-m24-0170-artifacts-feedback-2026-0829
branch
from
August 29, 2026 13:03
fd02269 to
cc21013
Compare
chalin
marked this pull request as ready for review
August 29, 2026 13:14
- Feedback from a 0.17.0 upgrade run over a site whose build re-syncs submodules, silently resetting a bare checkout
- Applies feedback from the 0.17.0 upgrade run: FA7 alias-vars survival note, sanity check widened to built HTML (fa-fw dropped from page-meta-links) - Adds the Agent support card entry (owner call; +1 overflow recorded in the release-prep wrapup)
- Owner call: the required-if-applies action takes the triangle like every other must-act line; the green check misread as nothing-to-do
- Blank-slate round: drops intra-release edit history and port provenance (PR-body facts); one entry, both PRs cited
- Use-lists round: five packed facts -> intro (breakage + fix) with two nested qualifiers, parallel with the Silent bullet - Drops the 'if you accept the no-stability caveat' gate (owner call): the section intro already carries the unsupported-surface frame, and the phrasing forced a false choice; google#2756 tracks a supported surface for 0.18
- Blank-slate review round (report in PR-branch tmp/): the intro paragraph flipped from observation to procedure mid-stream, and the fa-width-auto remedy was invisible from the Actions anchor - Narrows 'glyphs are redrawn' to the evidenced claim; sanity check now points at the actions
- Merges the two family-name gates plus the woff2 hotlink under one explicit-font-setup gate; splits the catch-all into an accessibility gate (semantic icons + sr-only utilities) and a layout-helpers/vector-square gate
chalin
force-pushed
the
chalin-m24-0170-artifacts-feedback-2026-0829
branch
from
August 29, 2026 19:24
f6ae541 to
6cfbebb
Compare
- git.md pin note: 'instead' made the exclusive reading the failing one; now pin-update AND re-sync, with CI-sync dropped from the applies-if - Card: gates the agent-support claim on enablement, adds experimental - Sanity check: names the agent directive among expected HTML diffs - Loud bullet: de-endorses 'the fix' phrasing; alias-vars claim scoped to variables (mixins can't be namespaced back)
- The hardcoded cells duplicated the version stamp (the docsy#2739 one-home rule); the param is release-only in every site variant, so Next previews keep showing the latest release
- Maintainer notes: the docsy-example release step now verifies the param-driven Examples table instead of manually updating cells the branch parameterized - Changelog: qualifies the lifecycle-name ban (unreviewed names; the reviewed pack hooks remain), matching the test's allowlist and the post's own account
- TUF-walkthrough review: the pin note misrouted sites whose tooling only syncs the gitlink (no separate pin to update); the staged gitlink is the durable pin, so staging is the universal protection, with the separate-pin case as the narrow exception
- Four independent review rounds flagged the BREAKING badge as a classification claim contradicting the section, triage, and changelog (owner concurrence): NEW badge restored; urgency carried by a⚠️ emoji and an explicit silent-failure clause instead
- Post-fixes review round: the silent-failure clause now names only pages using the overridden templates, and the built-output check expects the directive only for llms.txt-enabled sites; drops a literal em dash
chalin
changed the title
- Post freezes the tested sass-embedded pin as a page param and notes the @parcel/watcher lock entry (deny disposition, per the repo's own audit) - npm update page warns about the min-release-age ETARGET trap with the repo's canonical one-off override - GitHub-npm mode: CI-surviving install:theme-deps wiring; notes git deps bypass registry release gates
- @parcel/watcher disposition rehomes to Install Dart Sass (the evergreen owner); post keeps a linked delta - npm cooldown note gains the executable override command with explained placeholders - git.md: description takes the routing job (was a title echo); the commit step's blind re-stage instruction drops (it could replace the staged pin) - Changelog supply-chain entry recast as audit scope, dissolving the caveat-in-summary - Goldydocs term-gloss separator
chalin
force-pushed
the
chalin-m24-0170-artifacts-feedback-2026-0829
branch
from
August 30, 2026 10:19
e1ce0e9 to
75b31a3
Compare
chalin
force-pushed
the
chalin-m24-0170-artifacts-feedback-2026-0829
branch
from
August 30, 2026 12:13
6006d07 to
79680b3
Compare
…scopes) - npm update page: exact-version install becomes the primary path -- under min-release-age, @latest silently resolves to an older eligible release (repro'd) instead of the ETARGET the note promised - Post description: restores the scopes (semantic classes, UI-string coverage, llms.txt sites) - Dart Sass bullet: no-bundling claim scoped to standard binaries, linked to hugo#8299 (cache seeded) - @parcel/watcher def joins the sorted def block
- The bold lead and the two facts carry the benefit; the closer restated the lead in idiom
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
min-release-age,@latestsilently resolves to an older eligible release) and documents the one-off cooldown overrideNEWwith an explicit silent-failure warning@parcel/watcherlockfile entry thatsass-embeddedbrings (deniable install script)tdVersion.latest(one home for the version stamp); the maintainer-notes docsy-example step becomes verify-only