reject negative requested_digits in ToFixed - #298
Merged
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Collaborator
|
This is arguably something the caller should check and not do, but I'm in favor of catching it ourselves. |
Contributor
Author
|
Appreciate the merge, and thanks for taking it even without the CLA signed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repro:
ToFixed(1e-30, -1000, &builder)on a buffer sized by the header's own formula (1 + kMaxFixedDigitsBeforePoint + 1 + kMaxFixedDigitsAfterPoint + 1, so 163 bytes) returns true and writes 1000 characters; ASan reports a heap-buffer-overflow write inCreateDecimalRepresentation, and the length written is exactly-requested_digits.Cause:
requested_digitsis bounded only from above, so a negative count reachesCreateDecimalRepresentationasdecimal_point == -requested_digitsandAddPaddingemits that many characters. The lower bound existed only as theDOUBLE_CONVERSION_ASSERTinDoubleToAscii, which is compiled out under NDEBUG.ToFixed(1e-30, INT_MIN)additionally trips UBSan on the negation infixed-dtoa.cc:389.Fix: reject negative
requested_digitsup front, matching the guardsToExponentialandToPrecisionalready carry. Values 0 tokMaxFixedDigitsAfterPointare unaffected.