Skip to content

[GO] enhance golang object API to add 3 shortcut#5705

Closed
tsingson wants to merge 7 commits into
google:masterfrom
tsingson:master
Closed

[GO] enhance golang object API to add 3 shortcut#5705
tsingson wants to merge 7 commits into
google:masterfrom
tsingson:master

Conversation

@tsingson

@tsingson tsingson commented Jan 9, 2020

Copy link
Copy Markdown
Contributor
  1. object.Builder() --- shortcat of native object to flatbuffers Builder ( go method )
  2. object.Marshal() --- shortcut of native object Pack ( serialize method )
  3. UnmarshalObjectT(b []byte) *ObjectT --- shortcut of object UnPack ( un-serialize function )

1.  object.Builder()  --- shortcat of native object to flatbuffers Builder ( go method )
2. object.Marshal() --- shortcut of native object Pack, serialized object to binary array ( serialize method )
3. UnmarshalObjectT(b []byte) *ObjectT --- shortcut of object UnPack ( un-serialize  function  )
@somombo

somombo commented Jan 10, 2020

Copy link
Copy Markdown
Contributor

I feel there's no need for these changes since PR #5593, does the same things

@aardappel

Copy link
Copy Markdown
Collaborator

@somombo @tsingson @llchan can you guys work out which of these PRs should be merged first?

@tsingson did you run sh generate_code.sh ?

@tsingson

Copy link
Copy Markdown
Contributor Author

@somombo @tsingson @llchan can you guys work out which of these PRs should be merged first?

@tsingson did you run sh generate_code.sh ?

done. sh generate_code.sh been run.

@somombo

somombo commented Jan 10, 2020

Copy link
Copy Markdown
Contributor

not to be the party pooper here, but I think this PR should be closed in favor of PR #5593.
@llchan ?

I think our efforts along this line should be to try and help @llchan (if he needs the help) to perfect that PR

@tsingson

Copy link
Copy Markdown
Contributor Author

this PR closed.

i move on "--size-prefixed" option in go, my personal project need this.

thanks all for your comments.

@tsingson

Copy link
Copy Markdown
Contributor Author

yet

@tsingson tsingson closed this Jan 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants