fix bug: bool Array values are always false #8071
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
Can you add a test case to |
There are still some bugs in this fix, I'll take care of them later and add test cases. |
|
@Cindlory would you like me to pick up this PR & add a test? There's also an issue with how bools are encoded in general, addressed in #8252 |
@serprex no problem. Due to project changes at work, I put this issue on hold. My PR may not fix the problem, I remember it may be related to Lua's generated code. |
|
This pull request is stale because it has been open 6 months with no activity. Please comment or label |
|
This pull request was automatically closed due to no activity for 6 months plus the 14 day notice period. |
generating correct lua code involved using my fork of flatbuffers, I thought fixes would get merged upstream but flatbuffers maintainers ignored me google/flatbuffers#8071 google/flatbuffers#8251 google/flatbuffers#8252 google/flatbuffers#8254 google/flatbuffers#8258 google/flatbuffers#8262
3 participants
Using
[]in lua doesn't access the characters of a string, which results in the value of an array of type bool always being false