lua: fix bool encoding #8252
Closed
lua: fix bool encoding #8252
+22
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bools were being encoded as ASCII 0/1 instead of binary 0/1
Contributor
|
This pull request is stale because it has been open 6 months with no activity. Please comment or label |
Contributor
|
This pull request was automatically closed due to no activity for 6 months plus the 14 day notice period. |
serprex
added a commit
to PeerDB-io/peerdb
that referenced
this pull request
Feb 13, 2025
generating correct lua code involved using my fork of flatbuffers, I thought fixes would get merged upstream but flatbuffers maintainers ignored me google/flatbuffers#8071 google/flatbuffers#8251 google/flatbuffers#8252 google/flatbuffers#8254 google/flatbuffers#8258 google/flatbuffers#8262
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bools were being encoded as ASCII 0/1 instead of binary 0/1
Also fix issue @Cindlory noticed that strings do not expose numerical indexing