Propagate output directory creation failures - #9216
Open
xThreeh wants to merge 1 commit into
Open
Conversation
github-actions
Bot
added
python
c++
codegen
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
flatccurrently ignores failures while creating the output directory. If an intermediate path component is a file, generation reports an error but the process can still finish successfully.This change checks the output directory after
EnsureDirExists()and propagates the failure throughCompile(). It also adds a focused regression covering a valid output directory and an invalid path.Validation:
flatcwith CMake/Ninja.0and creates the generated header.git diff --checkpasses.The full native test target compiles, but the existing JSON golden comparison in
monster_test.cpp:829currently fails independently of this change.Fixes #9022