Update structure of MNIST example. - #634
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #634 +/- ##
=======================================
Coverage 80.59% 80.59%
=======================================
Files 56 56
Lines 4241 4241
=======================================
Hits 3418 3418
Misses 823 823 Continue to review full report at Codecov.
|
andsteing
self-requested a review
November 14, 2020 15:32
Contributor
|
Quoting from #231 :
I'm fine with any structure, but it should be the same for every example. If you think the structure proposed in this PR is superior, we should update #231 and make sure all of the examples follow the updated structure. |
Contributor
|
I agree. I updated #231. |
copybara-service
Bot
force-pushed
the
test_342404042
branch
from
November 14, 2020 21:03
bb6eac0 to
a4a5285
Compare
Contributor
|
Please also update the local imports in the Colab: |
This was referenced Nov 15, 2020
Closed
Closed
Marvin182
marked this pull request as draft
November 15, 2020 15:41
Contributor
|
done |
copybara-service
Bot
force-pushed
the
test_342404042
branch
from
November 15, 2020 15:43
a4a5285 to
88a3ff2
Compare
andsteing
approved these changes
Nov 15, 2020
copybara-service
Bot
force-pushed
the
test_342404042
branch
from
November 15, 2020 17:05
88a3ff2 to
e165074
Compare
- mnist_main.py -> main.py - mnist_lib.py -> train.py The main.py shouldn't be used in any test. PiperOrigin-RevId: 342517516
copybara-service
Bot
force-pushed
the
test_342404042
branch
from
November 15, 2020 17:24
e165074 to
0c6a8ba
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update structure of MNIST example.
The main.py shouldn't be used in any test.