Skip to content

Noto Sans Gujarati: Version 2.103 added - #6121

Merged
simoncozens merged 1 commit into
mainfrom
gftools_packager_ofl_notosansgujarati
Apr 4, 2023
Merged

Noto Sans Gujarati: Version 2.103 added#6121
simoncozens merged 1 commit into
mainfrom
gftools_packager_ofl_notosansgujarati

Conversation

@simoncozens

Copy link
Copy Markdown
Collaborator

f06afde: [gftools-packager] Noto Sans Gujarati: Version 2.103 added

@github-actions

Copy link
Copy Markdown
Contributor

Fontbakery report

Fontbakery version: 0.8.11

[1] Family checks
INFO: Check axis ordering on the STAT table. (com.google.fonts/check/STAT/axis_order)
  • INFO From a total of 1 font files, 0 of them (0.00%) lack a STAT table.

    And these are the most common STAT axis orderings:
    ('wght-wdth', 1) [code: summary]


[18] NotoSansGujarati[wdth,wght].ttf
🔥 FAIL: METADATA.pb: Check URL on copyright string is the same as in repository_url field. (com.google.fonts/check/metadata/consistent_repo_urls)

But font copyright string has: https://github.com/notofonts/gujarati
[code: mismatch]

🔥 FAIL: METADATA.pb: Designers are listed correctly on the Google Fonts catalog? (com.google.fonts/check/metadata/designer_profiles)
🔥 FAIL: Checking OS/2 usWinAscent & usWinDescent. (com.google.fonts/check/family/win_ascent_and_descent)
  • 🔥 FAIL OS/2.usWinAscent value should be equal or greater than 995, but got 896 instead [code: ascent]
🔥 FAIL: Font has **proper** whitespace glyph names? (com.google.fonts/check/whitespace_glyphnames)
  • 🔥 FAIL Glyph 0x00A0 is called "uni00A0.gujr": Change to "uni00A0" [code: non-compliant-00a0]
🔥 FAIL: Ensure soft_dotted characters lose their dot when combined with marks that replace the dot. (com.google.fonts/check/soft_dotted)
  • 🔥 FAIL The dot of soft dotted characters used in orthographies must disappear in the following strings: i̊ i̋ j̀ j́ j̃ j̄ j̈ į̀ į́ į̂ į̃ į̄ į̌

The dot of soft dotted characters should disappear in other cases, for example: ĩ ĭ i̇ ǐ i̒ ĩ̦ ĭ̦ i̦̇ i̦̊ i̦̋ ǐ̦ i̦̒ ĩ̧ ĭ̧ i̧̇ i̧̊ i̧̋ ǐ̧ i̧̒ ĵ [code: soft-dotted]

WARN: Checking OS/2 achVendID. (com.google.fonts/check/vendor_id)
  • WARN OS/2 VendorID value 'NONE' is not yet recognized. If you registered it recently, then it's safe to ignore this warning message. Otherwise, you should set it to your own unique 4 character code, and register it with Microsoft at https://www.microsoft.com/typography/links/vendorlist.aspx
    [code: unknown]
WARN: A static fonts directory with at least two fonts must accompany variable fonts (com.google.fonts/check/repo/vf_has_static_fonts)
  • WARN Please consider adding a subdirectory called "static/" and including in it static font files. [code: missing]
WARN: Ensure fonts have ScriptLangTags declared on the 'meta' table. (com.google.fonts/check/meta/script_lang_tags)
  • WARN This font file does not have a 'meta' table. [code: lacks-meta-table]
WARN: Check font contains no unreachable glyphs (com.google.fonts/check/unreachable_glyphs)
  • WARN The following glyphs could not be reached by codepoint or substitution rules:

    • asciicircum

    • asciitilde

    • asterisk

    • backslash

    • bar

    • braceleft

    • braceright

    • bracketleft

    • bracketright

    • charanuktaprehalfUIgujr

    • 65 more.

Use -F or --full-lists to disable shortening of long lists.
[code: unreachable-glyphs]

WARN: Does the font contain a soft hyphen? (com.google.fonts/check/soft_hyphen)
  • WARN This font has a 'Soft Hyphen' character. [code: softhyphen]
WARN: Detect any interpolation issues in the font. (com.google.fonts/check/interpolation_issues)
  • WARN Interpolation issues were found in the font: - Contour 1 start point differs in glyph 'uuvowelsignnuktagujr' between location <fontTools.ttLib.ttGlyphSet._TTGlyphSetGlyf object at 0x7fc881f5df90> and location <fontTools.ttLib.ttGlyphSet._TTGlyphSetGlyf object at 0x7fc881d91a20>

    • Contour 1 start point differs in glyph 'question.gujr' between location <fontTools.ttLib.ttGlyphSet._TTGlyphSetGlyf object at 0x7fc881f5df90> and location <fontTools.ttLib.ttGlyphSet._TTGlyphSetGlyf object at 0x7fc881f5ec50>

    • Contour 1 start point differs in glyph 'question.gujr' between location <fontTools.ttLib.ttGlyphSet._TTGlyphSetGlyf object at 0x7fc881f5df90> and location <fontTools.ttLib.ttGlyphSet._TTGlyphSetGlyf object at 0x7fc881d91a20>

    • Contour 1 start point differs in glyph 'question.gujr' between location <fontTools.ttLib.ttGlyphSet._TTGlyphSetGlyf object at 0x7fc881f5df90> and location <fontTools.ttLib.ttGlyphSet._TTGlyphSetGlyf object at 0x7fc881d90100>

    • Contour 1 start point differs in glyph 'question.gujr' between location <fontTools.ttLib.ttGlyphSet._TTGlyphSetGlyf object at 0x7fc881f5df90> and location <fontTools.ttLib.ttGlyphSet._TTGlyphSetGlyf object at 0x7fc881d92680>

    • Contour 1 start point differs in glyph 'question.gujr' between location <fontTools.ttLib.ttGlyphSet._TTGlyphSetGlyf object at 0x7fc881f5df90> and location <fontTools.ttLib.ttGlyphSet._TTGlyphSetGlyf object at 0x7fc881d935e0> [code: interpolation-issues]

INFO: Show hinting filesize impact. (com.google.fonts/check/hinting_impact)
  • INFO Hinting filesize impact:
ofl/notosansgujarati/NotoSansGujarati[wdth,wght].ttf
Dehinted Size 672.7kb
Hinted Size 672.8kb
Increase 24 bytes
Change 0.0 %
[code: size-impact]
INFO: Font has old ttfautohint applied? (com.google.fonts/check/old_ttfautohint)
  • INFO Could not detect which version of ttfautohint was used in this font. It is typically specified as a comment in the font version entries of the 'name' table. Such font version strings are currently: ['Version 2.103'] [code: version-not-detected]
INFO: EPAR table present in font? (com.google.fonts/check/epar)
INFO: Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering? (com.google.fonts/check/gasp)
  • INFO These are the ppm ranges declared on the gasp table:

PPM <= 65535:
flag = 0x0F
- Use grid-fitting
- Use grayscale rendering
- Use gridfitting with ClearType symmetric smoothing
- Use smoothing along multiple axes with ClearType®
[code: ranges]

INFO: Check for font-v versioning. (com.google.fonts/check/fontv)
  • INFO Version string is: "Version 2.103"
    The version string must ideally include a git commit hash and either a "dev" or a "release" suffix such as in the example below:
    "Version 1.3; git-0d08353-release" [code: bad-format]
INFO: Font contains all required tables? (com.google.fonts/check/required_tables)
  • INFO This font contains the following optional tables:

    • loca

    • prep

    • GPOS

    • GSUB

    • gasp [code: optional-tables]

INFO: List all superfamily filepaths (com.google.fonts/check/superfamily/list)
  • INFO ofl/notosansgujarati [code: family-path]

Summary

💔 ERROR 🔥 FAIL ⚠ WARN 💤 SKIP ℹ INFO 🍞 PASS 🔎 DEBUG
0 5 6 39 8 184 0
0% 2% 2% 16% 3% 76% 0%

Note: The following loglevels were omitted in this report:

  • SKIP
  • PASS
  • DEBUG

@m4rc1e m4rc1e left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see Latin kerning has been included.

In the Gujarati, it seems that a dot above has been replaced by a candrabindu in some diffenator reports. @simoncozens if this is intentional then LGTM, feel free to merge.

@simoncozens

Copy link
Copy Markdown
Collaborator Author

Sorry, forgot the release notes:

This release:

  • Decomposes vertical matras when forming ligatures
  • Fixes an issue where candrabindus would turn into anusvaras
  • Adds an anchor on the AI vowel

@simoncozens
simoncozens merged commit 267b1d5 into main Apr 4, 2023
@simoncozens
simoncozens deleted the gftools_packager_ofl_notosansgujarati branch April 4, 2023 07:35
@m4rc1e

m4rc1e commented Apr 4, 2023

Copy link
Copy Markdown
Collaborator

Sweet. Thank you!

@RosaWagner

Copy link
Copy Markdown
Contributor

@simoncozens @m4rc1e was that PR supposed to be merged? There is no label and it is not in traffic jam.

@m4rc1e

m4rc1e commented Apr 5, 2023

Copy link
Copy Markdown
Collaborator

Yep, apologies for missing the other stuff.

@simoncozens

Copy link
Copy Markdown
Collaborator Author

It was supposed to be merged, my fault for not labelling it up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants