Pass runtime_config_ to the KVCache constructor within GemmaEnv in benchmark_helper.cc. This ensures that kv_cache_type and attention_impl settings are properly propagated when using non-default attention implementations such as flash_transposed_qs_bf16.#956
Merged
Conversation
copybara-service
Bot
force-pushed
the
test_949005324
branch
2 times, most recently
from
July 17, 2026 08:45
a8cae0c to
fc6213f
Compare
…nchmark_helper.cc. This ensures that kv_cache_type and attention_impl settings are properly propagated when using non-default attention implementations such as flash_transposed_qs_bf16. PiperOrigin-RevId: 949438536
copybara-service
Bot
force-pushed
the
test_949005324
branch
from
July 17, 2026 08:55
fc6213f to
7a8c621
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pass runtime_config_ to the KVCache constructor within GemmaEnv in benchmark_helper.cc. This ensures that kv_cache_type and attention_impl settings are properly propagated when using non-default attention implementations such as flash_transposed_qs_bf16.