Fix and document the --attention_impl flag - #967
Merged
Conversation
RaviTriv
marked this pull request as ready for review
July 27, 2026 23:30
jan-wassenberg
added
the
copybara-import
jan-wassenberg
added
copybara-import
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ran into some issues when messing around with using
--attention_implflag, proposed changes to document and fix :)k_tile_vec,v_tile_vecand init them inAttentionActivationsPtrsto fix segfault../build/gemma --weights ~/development/gemma-weights/1b/1b-it-sfp.sbs --attention_impl flash_transposed_qs_bf16 --prompt "Where is Brampton?"Current
Updated
