Refactor volume.Format and add formatting helpers. - #416
Merged
Conversation
copybara-service
Bot
force-pushed
the
test_390190240
branch
2 times, most recently
from
August 12, 2021 14:27
6c994b6 to
c8b837a
Compare
This unfortunately breaks existing uses of the Format function, but the original design of the function was not scaling well, didn't read well, and didn't work for FAT32. PiperOrigin-RevId: 390367626
copybara-service
Bot
force-pushed
the
test_390190240
branch
from
August 12, 2021 14:35
c8b837a to
724d72f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor volume.Format and add formatting helpers.
This unfortunately breaks existing uses of the Format function, but the original design of the function was not scaling well, didn't read well, and didn't work for FAT32.