Skip to content

Change size and alignment to uint64 based on findings in cl/393119620. #424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
copybara-service merged 1 commit into from
Aug 30, 2021
Merged

Change size and alignment to uint64 based on findings in cl/393119620. #424

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions go/storage/disk.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,7 @@ var GptTypes = struct {
// CreatePartition(0, true, 0, 0, "", true, &storage.MbrTypes.FAT32, nil, false, true)
//
// Ref: https://docs.microsoft.com/en-us/previous-versions/windows/desktop/stormgmt/createpartition-msft-disk
func (d *Disk) CreatePartition(size int, useMaximumSize bool, offset int, alignment int, driveLetter string, assignDriveLetter bool,
func (d *Disk) CreatePartition(size uint64, useMaximumSize bool, offset uint64, alignment int, driveLetter string, assignDriveLetter bool,
mbrType *MbrType, gptType *GptType, hidden, active bool) (Partition, ExtendedStatus, error) {
part := Partition{}
stat := ExtendedStatus{}
Expand Down Expand Up @@ -209,7 +209,7 @@ func (d *Disk) CreatePartition(size int, useMaximumSize bool, offset int, alignm

var ioffset interface{}
if offset > 0 {
ioffset = offset
ioffset = strconv.FormatUint(offset, 10)
} else {
ioffset = nil
}
Expand All @@ -218,7 +218,7 @@ func (d *Disk) CreatePartition(size int, useMaximumSize bool, offset int, alignm
if useMaximumSize {
isize = nil
} else {
isize = size
isize = strconv.FormatUint(size, 10)
}

var createdPartition ole.VARIANT
Expand Down