Refactoring helpers.Exec io handling (again). - #445
Merged
Conversation
copybara-service
Bot
force-pushed
the
test_406186726
branch
2 times, most recently
from
October 28, 2021 18:55
52587cd to
335312a
Compare
copybara-service
Bot
changed the title
copybara-service
Bot
force-pushed
the
test_406186726
branch
2 times, most recently
from
October 29, 2021 14:54
f41628b to
02b369f
Compare
Do away with unique handling depending on the type of input to stderr/stdout writers as this greatly complicated the other features of Exec like validation. Instead: * Always allocate our own buffer to receive a copy of stderr/stdout. This avoids a problem where interacting with the buffer inside the helper potentially consumes or modifies it before it gets returned. * Use a Multiwriter to copy all stderr/stdout to any user supplied writers; this allows the caller's own writers to receive output as its written, while keeping a copy for the helper to use at the end. * cmd.Stdout and cmd.Stderr are always supplied a writer (either multi or single) * result.Stdout and result.Stderr always get copies of the outputs PiperOrigin-RevId: 406359841
copybara-service
Bot
force-pushed
the
test_406186726
branch
from
October 29, 2021 15:02
02b369f to
5992d81
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactoring helpers.Exec io handling (again).
Do away with unique handling depending on the type of input to stderr/stdout writers as this greatly complicated the other features of Exec like validation. Instead: