cmd.Wait() for a non 0 exit code is filled with metadata (it's assuming any non 0 exit code is bad), by pinning verify on this being nil means we are doing the same - #616
Merged
Conversation
copybara-service
Bot
force-pushed
the
test_463828067
branch
5 times, most recently
from
July 28, 2022 20:42
4a16dbc to
b3fffea
Compare
…ng any non 0 exit code is bad), by pinning verify on this being nil means we are doing the same ``` The returned error is nil if the command runs, has no problems copying stdin, stdout, and stderr, and exits with a zero exit status. ``` Do some additional parsing of res.ExitErr first to not bail on verification if ExitErr contains a "bad" exit status and let the additional checks determine if the run was bad. PiperOrigin-RevId: 463916936
copybara-service
Bot
force-pushed
the
test_463828067
branch
from
July 28, 2022 20:49
b3fffea to
b20e1fe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cmd.Wait() for a non 0 exit code is filled with metadata (it's assuming any non 0 exit code is bad), by pinning verify on this being nil means we are doing the same
Do some additional parsing of res.ExitErr first to not bail on verification if ExitErr contains a "bad" exit status and let the additional checks determine if the run was bad.