Skip to content

Update actions.md: correct UpdateMSU options - #701

Merged
mit-da merged 4 commits into
google:masterfrom
iamacarpet:patch-1
Jan 10, 2024
Merged

Update actions.md: correct UpdateMSU options#701
mit-da merged 4 commits into
google:masterfrom
iamacarpet:patch-1

Conversation

@iamacarpet

@iamacarpet iamacarpet commented Jul 21, 2023

Copy link
Copy Markdown
Contributor

The example for UpdateMSU in the docs is misleading.

The option need to be an array of updates, each itself an array of arguments.

@google-cla

google-cla Bot commented Jul 21, 2023

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@TsekNet TsekNet left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Can you move each list argument to it's own line to make it easier for humans to read?

@TsekNet

TsekNet commented Jan 2, 2024

Copy link
Copy Markdown
Contributor

ping @iamacarpet

@iamacarpet

Copy link
Copy Markdown
Contributor Author

Sorry @TsekNet , I'll get this sorted.

@iamacarpet

Copy link
Copy Markdown
Contributor Author

There we go @TsekNet ,

I hope you don't mind me also documenting the argument list, as I found myself having to dive into the code again to confirm the hash format (until I realised I could guess it from the hash length, but that isn't the point) :).

@mit-da
mit-da merged commit 410eb25 into google:master Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants