pass in the ca_cert_file for unverified downloads to fix basedownloader for new python version. - #754
Merged
Merged
Conversation
copybara-service
Bot
force-pushed
the
test_745551029
branch
2 times, most recently
from
April 9, 2025 12:56
303fcb8 to
5d4442a
Compare
…er for new python version. note: this is a workaround for Python 3.12.9 and we should move to using ssl.SSLContext.load_cert_chain() instead, or let ssl.create_default_context() select the system’s trusted CA certificates for us. PiperOrigin-RevId: 745554361
copybara-service
Bot
force-pushed
the
test_745551029
branch
from
April 9, 2025 13:01
5d4442a to
a94d8f9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pass in the ca_cert_file for unverified downloads to fix basedownloader for new python version.
note: this is a workaround for Python 3.12.9 and we should move to using ssl.SSLContext.load_cert_chain() instead, or let ssl.create_default_context() select the system’s trusted CA certificates for us.