Include a commit with K8s 1.20 libs #1027
Conversation
|
Is this a flakey test?
|
Yep 😢 This change sgtm |
pkg/authn/k8schain/go.mod
Outdated
|
|
||
| require ( | ||
| github.com/docker/spdystream v0.0.0-20160310174837-449fdfce4d96 // indirect | ||
| github.com/fsnotify/fsnotify v1.4.9 // indirect |
There was a problem hiding this comment.
yeah let me re-run the commands
There was a problem hiding this comment.
https://github.com/kubernetes/apimachinery/blob/v0.21.1/go.mod#L21
fsnotify is from gomega which k8s uses
There was a problem hiding this comment.
it's not obvious to me why the go tool chain made it show up as //indirect here
There was a problem hiding this comment.
fsnotify remained - I deleted all //indirect dependencies and ran go mod tidy again
This reverts commit f009e5f.
Codecov Report
@@ Coverage Diff @@
## main #1027 +/- ##
=======================================
Coverage 75.03% 75.03%
=======================================
Files 107 107
Lines 5072 5072
=======================================
Hits 3806 3806
Misses 720 720
Partials 546 546 Continue to review full report at Codecov.
|
|
/hold one sec |
dprotaso
force-pushed
the
k8schain-k8s
branch
2 times, most recently
from
27f0910 to
a1dcf6e
Compare
|
hmm.. did you squash the commits? |
|
See green button. Push green button. 🐒 |
4 participants
I'm trying to bump Knative's K8s dependency to 1.20 - but this repo skipped 1.20 to 1.21.
I'm hoping this PR is a noop for most - but gives me the ability to target a specific commit that uses K8s 1.20.x deps.
Thus I'm expecting the commit history to not be squashed