Add pkg/registry/README.md documenting expectations #1167
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Of course. That PR doesn't violate this README. If this said what Jon's comment said (only the Go stdlib), then it certainly would have prompted some further discussion. |
mattmoor
approved these changes
Nov 5, 2021
Contributor
Author
|
I was expecting @jonjohnsonjr to weigh in before merging. Perhaps I could have said that explicitly. @jonjohnsonjr if you have more comments please let me know and I'll send another PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1158
@mattmoor would the presence of this README have helped prevent the situation in #1158 ?