Fix NewKeychainFromHelper #1265
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- only pass RegistryStr, since helpers don't expect to see repo paths, and might not handle them correctly - if the returned username is "<token>", interpret the returned password as an identity token - add unit tests to cover both of these behaviors
Codecov Report
@@ Coverage Diff @@
## main #1265 +/- ##
=======================================
Coverage 73.77% 73.78%
=======================================
Files 111 111
Lines 8286 8289 +3
=======================================
+ Hits 6113 6116 +3
Misses 1571 1571
Partials 602 602
Continue to review full report at Codecov.
|
mattmoor
approved these changes
Jan 25, 2022
| return Anonymous, nil | ||
| } | ||
| // If the secret being stored is an identity token, the Username should be set to <token> | ||
| // ref: https://docs.docker.com/engine/reference/commandline/login/#credential-helper-protocol |
This was referenced Jan 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and might not handle them correctly
as an identity token
This builds on the excellent work done by @simongottschlag in #1256, and adds unit tests.