Skip to content

Conversation

@imjasonh
Copy link
Contributor

@imjasonh imjasonh commented Oct 22, 2020

By having pkg/crane/copy_test.go set up its fake registry at gcr.io, this seems to trigger behavior that ends up looking for default GCP credentials to authorize pushes/pulls. This works fine when tests run in GCB, and presumably on most of our local workstations, where GCP creds happen to be available, but fails on GitHub Actions, where creds are not available.

Instead of calling our fake registry "gcr.io", this change renames it to "xcr.io".

This change includes the Unit Tests action being added by #792, to check that this change fixes the unit test failure.

@imjasonh imjasonh changed the title WIP: Try to remove hidden unit test dependency on GCR creds Remove hidden unit test dependency on GCR creds Oct 22, 2020
@imjasonh
Copy link
Contributor Author

cc @mattmoor

@codecov-io
Copy link

codecov-io commented Oct 22, 2020

Codecov Report

Merging #793 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #793   +/-   ##
=======================================
  Coverage   75.54%   75.54%           
=======================================
  Files         102      102           
  Lines        4171     4171           
=======================================
  Hits         3151     3151           
  Misses        566      566           
  Partials      454      454           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a28419...b19fa10. Read the comment docs.

@mattmoor mattmoor merged commit e4f0bba into google:master Oct 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants