Skip to content

feat: Add org level secret scanning custom patterns support - #4426

Merged
gmlewis merged 1 commit into
google:masterfrom
tanayarun:secret-scanning-custom-patterns-org
Aug 1, 2026
Merged

feat: Add org level secret scanning custom patterns support#4426
gmlewis merged 1 commit into
google:masterfrom
tanayarun:secret-scanning-custom-patterns-org

Conversation

@tanayarun

Copy link
Copy Markdown
Contributor

Adds support for managing secret scanning custom patterns at the
organization level: list, create, update, and delete.

Related to #4381. This is the second of three planned PRs to fully
resolve the issue.

  • Added ListCustomPatternsForOrg, CreateCustomPatternsForOrg,
    UpdateCustomPatternForOrg, DeleteCustomPatternsForOrg to
    SecretScanningService, reusing the request/response types and
    SecretScanningCustomPatternListOptions from feat: Add repo-level secret scanning custom patterns support #4397
  • Ran go generate ./... to update iterators
  • Added table driven tests for all four methods

@codecov

codecov Bot commented Aug 1, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.54%. Comparing base (4d45b7c) to head (7ae3241).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4426   +/-   ##
=======================================
  Coverage   97.54%   97.54%           
=======================================
  Files         194      194           
  Lines       19780    19836   +56     
=======================================
+ Hits        19294    19350   +56     
  Misses        268      268           
  Partials      218      218           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tanayarun

Copy link
Copy Markdown
Contributor Author

Hey, @gmlewis sorry for the delay.
Can you review the pr and lemme know the required changes.

@gmlewis gmlewis added the NeedsReview PR is awaiting a review before merging. label Aug 1, 2026

@gmlewis gmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @tanayarun!
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.

cc: @stevehipwell - @alexandear - @Not-Dhananjay-Mishra

@Not-Dhananjay-Mishra Not-Dhananjay-Mishra left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gmlewis gmlewis removed the NeedsReview PR is awaiting a review before merging. label Aug 1, 2026
@gmlewis

gmlewis commented Aug 1, 2026

Copy link
Copy Markdown
Collaborator

Thank you, @Not-Dhananjay-Mishra!
Merging.

@gmlewis
gmlewis merged commit e496a87 into google:master Aug 1, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants