chore: Remove stale User entry from the paramcheck allowlist - #4437
Merged
gmlewis merged 1 commit intoAug 6, 2026
Merged
Conversation
Follow-up to google#4433: UsersService.Update now takes UserUpdateRequest by value, so User is no longer used as a request body anywhere and its body-allowed-pointer-types exception is dead. Removing it produces no paramcheck findings.
gmlewis
approved these changes
Aug 6, 2026
gmlewis
left a comment
gmlewis
left a comment
Collaborator
There was a problem hiding this comment.
Thank you, @JamBalaya56562!
LGTM.
Merging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #4433.
That PR converted
UsersService.Updateto take the newUserUpdateRequestby value, which was the only placeUserwas used as a request body. The correspondingUserentry in theparamcheckbody-allowed-pointer-typesallowlist (whose header says "TODO: fix and remove these exceptions") became dead but wasn't removed.This removes the entry. Verified that
custom-gclreports noparamcheckfindings with the exception gone, confirming nothing still passes*Useras a request body. For reference,UserUpdateRequestitself matches the documentedPATCH /userschema exactly (all eight parameters optional), so no further follow-up is needed there.Updates #3644