Skip to content

Fix KnownName() and Empty Buffer sequence handle Names#371

Merged
chrisfenner merged 4 commits intogoogle:mainfrom
nckrss:370-bugfix-knownname-and-sequence-names
Sep 20, 2024
Merged

Fix KnownName() and Empty Buffer sequence handle Names#371
chrisfenner merged 4 commits intogoogle:mainfrom
nckrss:370-bugfix-knownname-and-sequence-names

Conversation

@nckrss
Copy link
Copy Markdown
Contributor

@nckrss nckrss commented Sep 20, 2024

This PR resolves a bug introduced to KnownName handling and introduces a struct tag for commands that allow for the Name to be the Empty Buffer, namely TPM2_SequenceUpdate and TPM2_SequenceComplete.

  • Add tests for multiple transient objects in an HMAC sequence
  • Handle special case for sequence object handle Name fields
  • Relax HmacStart.Handle type from AuthHandle to handle
  • Fix prior RSA test that silently succeeded due to KnownName() bug

Fixes #370

@nckrss nckrss requested review from a team, alexmwu and jkl73 as code owners September 20, 2024 14:39
@chrisfenner
Copy link
Copy Markdown
Member

Thank you so much for the bug report and the accompanying fix, @nckrss!

@chrisfenner chrisfenner merged commit 364d5f2 into google:main Sep 20, 2024
@nckrss nckrss deleted the 370-bugfix-knownname-and-sequence-names branch September 20, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Invalid handling of KnownName() and Empty Buffer responses

2 participants