Remove net webmockhttpresponse#331
Closed
ysksn wants to merge 3 commits intogoogleapis:masterfrom
ysksn:remove_net_webmockhttpresponse
Closed
Remove net webmockhttpresponse#331ysksn wants to merge 3 commits intogoogleapis:masterfrom ysksn:remove_net_webmockhttpresponse
ysksn wants to merge 3 commits intogoogleapis:masterfrom
ysksn:remove_net_webmockhttpresponse
Conversation
googlebot
added
the
cla: yes
Contributor
|
Please keep for now since I'm still planning on supporting both net::http and httpclient for the near future. That particular bit of code relates to monkey patching webmock for a specific test (broken connection during streaming.) |
Contributor
Author
|
i see |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This module used nowhere. Do we still need it?
thanks :)