Improve interactions between wroteAnythingSignificant and whitespace requests.#1414
Merged
Conversation
…e requests. Mainly, make all whitespace requests into no-ops if we haven't written anything significant yet. This lets us remove various existing special cases. But also, start setting `wroteAnythingSignificant` in some locations where we write to `output` without using `writeToken` (which would set `wroteAnythingSignificant` automatically). PiperOrigin-RevId: 945842813
copybara-service
Bot
force-pushed
the
test_945762339
branch
from
19f9aa0 to
e4cef58
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve interactions between
wroteAnythingSignificantand whitespace requests.Mainly, make all whitespace requests into no-ops if we haven't written anything significant yet. This lets us remove various existing special cases.
But also, start setting
wroteAnythingSignificantin some locations where we write tooutputwithout usingwriteToken(which would setwroteAnythingSignificantautomatically).