Merged capture and drop fragment#3376
Closed
anandwana001 wants to merge 1 commit intogoogle:masterfrom
Closed
Conversation
shobhitagarwal1612
requested changes
Dec 2, 2025
...rc/main/java/org/groundplatform/android/ui/datacollection/tasks/point/DropPinTaskFragment.kt
Show resolved
Hide resolved
...main/java/org/groundplatform/android/ui/datacollection/tasks/point/DropPinTaskMapFragment.kt
Show resolved
Hide resolved
...main/java/org/groundplatform/android/ui/datacollection/tasks/point/DropPinTaskMapFragment.kt
Show resolved
Hide resolved
Member
There was a problem hiding this comment.
Shouldn't these lines not be deleted in this PR as we are planning to preserve existing logic too?
Collaborator
Author
There was a problem hiding this comment.
we are shifting all this to AbstractTaskViewModel, and incase keeping this will not work as "'enableLocationLockFlow' hides member of supertype 'AbstractTaskViewModel' and needs an 'override' modifier" will throw such error.
...main/java/org/groundplatform/android/ui/datacollection/tasks/point/DropPinTaskMapFragment.kt
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards #3148
PR 2 as per #3341 (comment)
@shobhitagarwal1612 PTAL?