Skip to content

Implement new proto param to allow Other sellection as a conditional expression#3832

Merged
andreia-ferreira merged 4 commits into
masterfrom
andreia/3821/conditional-other
Jul 10, 2026
Merged

Implement new proto param to allow Other sellection as a conditional expression#3832
andreia-ferreira merged 4 commits into
masterfrom
andreia/3821/conditional-other

Conversation

@andreia-ferreira

Copy link
Copy Markdown
Collaborator

Fixes #3821

This PR updates the Ground platform commit to a newer one containing changes to the MultipleChoiceSelection proto. The new parameter other_selected allows the selection of the 'Other' option to be used for conditional tasks.
A database auto migration was also added in order to insert the new column, which defaults to false for existing surveys.

Screen_recording_20260710_152345.webm

@shobhitagarwal1612 PTAL?

@codecov

codecov Bot commented Jul 10, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 46.15385% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 67.48%. Comparing base (31b524c) to head (3c28bbf).

Files with missing lines Patch % Lines
.../org/groundplatform/domain/model/task/Condition.kt 0.00% 7 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #3832      +/-   ##
============================================
- Coverage     67.49%   67.48%   -0.01%     
- Complexity     1797     1798       +1     
============================================
  Files           405      405              
  Lines         10625    10632       +7     
  Branches       1356     1358       +2     
============================================
+ Hits           7171     7175       +4     
- Misses         2756     2759       +3     
  Partials        698      698              
Files with missing lines Coverage Δ
...ava/org/groundplatform/android/common/Constants.kt 100.00% <ø> (ø)
...dplatform/android/data/local/room/LocalDatabase.kt 100.00% <ø> (ø)
.../android/data/local/room/converter/ConverterExt.kt 84.33% <100.00%> (+0.10%) ⬆️
...android/data/local/room/entity/ExpressionEntity.kt 100.00% <100.00%> (ø)
.../data/remote/firebase/schema/ConditionConverter.kt 100.00% <100.00%> (ø)
.../org/groundplatform/domain/model/task/Condition.kt 0.00% <0.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@andreia-ferreira andreia-ferreira merged commit 247e500 into master Jul 10, 2026
19 checks passed
@andreia-ferreira andreia-ferreira deleted the andreia/3821/conditional-other branch July 10, 2026 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Evaluate task conditions against the "Other" answer (MultipleChoiceSelection.other_selected)

2 participants