Add overlay components for the PDF map - #3857
Merged
Merged
Conversation
andreia-ferreira
requested a deployment
to
e2e-approval
July 24, 2026 10:41 — with
GitHub Actions
Waiting
shobhitagarwal1612
approved these changes
Jul 24, 2026
andreia-ferreira
temporarily deployed
to
e2e-approval
July 27, 2026 08:04 — with
GitHub Actions
Inactive
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #3857 +/- ##
============================================
+ Coverage 67.40% 67.48% +0.08%
- Complexity 1840 1849 +9
============================================
Files 407 410 +3
Lines 10759 10818 +59
Branches 1420 1428 +8
============================================
+ Hits 7252 7301 +49
- Misses 2762 2769 +7
- Partials 745 748 +3
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards #3839
This PR introduces the overlay components for the map which will be included in the PDF report:
NorthArrowLayout: a triangle with a 'N' label, to be displayed on the map top right cornerScaleBarLayout: a scale bar with a distance displayed centered above. ThescaleLabelwhich was introduced in a previous PR has been removed from theMapBlockas it's not needed since the chosen approach is to display the scale as a bar in the map snapshotPdfCanvasthedrawMapOverlaymethod to draw the new components@shobhitagarwal1612 PTAL?