Skip to content

Add overlay components for the PDF map - #3857

Merged
andreia-ferreira merged 6 commits into
masterfrom
andreia/3715/add-north-arrow-and-scale
Jul 27, 2026
Merged

Add overlay components for the PDF map #3857
andreia-ferreira merged 6 commits into
masterfrom
andreia/3715/add-north-arrow-and-scale

Conversation

@andreia-ferreira

Copy link
Copy Markdown
Collaborator

Towards #3839

This PR introduces the overlay components for the map which will be included in the PDF report:

  • NorthArrowLayout: a triangle with a 'N' label, to be displayed on the map top right corner
  • ScaleBarLayout: a scale bar with a distance displayed centered above. The scaleLabel which was introduced in a previous PR has been removed from the MapBlock as it's not needed since the chosen approach is to display the scale as a bar in the map snapshot
  • Added to PdfCanvas the drawMapOverlay method to draw the new components

@shobhitagarwal1612 PTAL?

@codecov

codecov Bot commented Jul 27, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 84.61538% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 67.48%. Comparing base (0f57b1e) to head (6f6c6a1).

Files with missing lines Patch % Lines
...ndplatform/feature/pdf/render/DocumentPdfCanvas.kt 75.86% 6 Missing and 1 partial ⚠️
...rm/feature/pdf/render/layout/map/ScaleBarLayout.kt 88.88% 0 Missing and 2 partials ⚠️
...org/groundplatform/feature/pdf/render/PdfCanvas.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #3857      +/-   ##
============================================
+ Coverage     67.40%   67.48%   +0.08%     
- Complexity     1840     1849       +9     
============================================
  Files           407      410       +3     
  Lines         10759    10818      +59     
  Branches       1420     1428       +8     
============================================
+ Hits           7252     7301      +49     
- Misses         2762     2769       +7     
- Partials        745      748       +3     
Files with missing lines Coverage Δ
...groundplatform/feature/pdf/render/PdfTextPaints.kt 100.00% <100.00%> (ø)
...oundplatform/feature/pdf/mapper/LoiReportMapper.kt 91.04% <ø> (-0.14%) ⬇️
...latform/feature/pdf/model/SubmissionPdfDocument.kt 92.59% <100.00%> (-0.96%) ⬇️
...rg/groundplatform/feature/pdf/render/MapOverlay.kt 100.00% <100.00%> (ø)
.../feature/pdf/render/layout/map/NorthArrowLayout.kt 100.00% <100.00%> (ø)
...org/groundplatform/feature/pdf/render/PdfCanvas.kt 83.33% <0.00%> (-16.67%) ⬇️
...rm/feature/pdf/render/layout/map/ScaleBarLayout.kt 88.88% <88.88%> (ø)
...ndplatform/feature/pdf/render/DocumentPdfCanvas.kt 68.08% <75.86%> (+12.52%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@andreia-ferreira
andreia-ferreira merged commit 4b17121 into master Jul 27, 2026
19 checks passed
@andreia-ferreira
andreia-ferreira deleted the andreia/3715/add-north-arrow-and-scale branch July 27, 2026 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants