Update code and docs for minimum Android API level 24 - #3085
Merged
eamonnmcmanus merged 2 commits intoAug 5, 2026
Conversation
The overridden methods for NonNullElementWrapperList are already covered by the tests in JsonArrayAsListTest.
Marcono1234
commented
Aug 5, 2026
Comment on lines
+122
to
+130
| @Override | ||
| public void sort(Comparator<? super E> c) { | ||
| delegate.sort(c); | ||
| } | ||
|
|
||
| @Override | ||
| public Spliterator<E> spliterator() { | ||
| return delegate.spliterator(); | ||
| } |
Contributor
Author
There was a problem hiding this comment.
These are already covered by the tests in JsonArrayAsListTest.
The minimum API level for the `check-android-compatibility` check had been increased to 23, but it seems there was no usage from that API level.
eamonnmcmanus
approved these changes
Aug 5, 2026
eamonnmcmanus
left a comment
eamonnmcmanus
left a comment
Member
There was a problem hiding this comment.
Thanks for doing this! I had meant to update the documentation, but I hadn't thought of all those other changes.
|
|
||
| #### Minimum Android API level | ||
|
|
||
| - Gson 2.15.0 and newer: API level 24 |
Member
There was a problem hiding this comment.
I had been planning on releasing 2.14.1 next, but I think you're right that the change in Android SDK level implies upping the minor level.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Follow-up for #3082
Description