Ensure that GWT artifacts are present in the Maven central repositories as part of release process. #501

Closed
gissuebot opened this Issue Oct 31, 2014 · 28 comments

Comments

Projects
None yet
3 participants
@gissuebot

Original issue created by t.broyer on 2010-12-17 at 09:46 AM


If you want to use Guava in a GWT project, you currently have to deploy the guava-r07-gwt.jar in your own Maven repository, as it's not on Maven Central.

Not a show stopper for us, but it would be much better if we weren't force to do it (and repeat it when we'll switch to r08)

@gissuebot

This comment has been minimized.

Show comment
Hide comment
@gissuebot

gissuebot Oct 31, 2014

Original comment posted by kevinb@google.com on 2011-01-12 at 10:02 PM


(No comment entered for this change.)


Status: Accepted
Owner: cgruberatgoog
Labels: Type-Task

Original comment posted by kevinb@google.com on 2011-01-12 at 10:02 PM


(No comment entered for this change.)


Status: Accepted
Owner: cgruberatgoog
Labels: Type-Task

@gissuebot

This comment has been minimized.

Show comment
Hide comment
@gissuebot

gissuebot Oct 31, 2014

Original comment posted by cgruber@google.com on 2011-01-13 at 03:50 PM


I'll work on it this coming week.

Christian.

Original comment posted by cgruber@google.com on 2011-01-13 at 03:50 PM


I'll work on it this coming week.

Christian.

@gissuebot

This comment has been minimized.

Show comment
Hide comment
@gissuebot

gissuebot Oct 31, 2014

Original comment posted by kevinb@google.com on 2011-01-20 at 06:56 PM


(No comment entered for this change.)


Labels: Milestone-Release08

Original comment posted by kevinb@google.com on 2011-01-20 at 06:56 PM


(No comment entered for this change.)


Labels: Milestone-Release08

@gissuebot

This comment has been minimized.

Show comment
Hide comment
@gissuebot

gissuebot Oct 31, 2014

Original comment posted by kevinb@google.com on 2011-01-27 at 06:16 AM


(No comment entered for this change.)


Status: Started

Original comment posted by kevinb@google.com on 2011-01-27 at 06:16 AM


(No comment entered for this change.)


Status: Started

@gissuebot

This comment has been minimized.

Show comment
Hide comment
@gissuebot

gissuebot Oct 31, 2014

Original comment posted by fry@google.com on 2011-03-24 at 02:24 PM


(No comment entered for this change.)


Status: Fixed

Original comment posted by fry@google.com on 2011-03-24 at 02:24 PM


(No comment entered for this change.)


Status: Fixed

@gissuebot

This comment has been minimized.

Show comment
Hide comment
@gissuebot

gissuebot Oct 31, 2014

Original comment posted by cgdecker on 2011-03-24 at 04:49 PM


Just checking, but should this really be marked fixed? I don't see any sign of the GWT jar in maven central.

Original comment posted by cgdecker on 2011-03-24 at 04:49 PM


Just checking, but should this really be marked fixed? I don't see any sign of the GWT jar in maven central.

@gissuebot

This comment has been minimized.

Show comment
Hide comment
@gissuebot

gissuebot Oct 31, 2014

Original comment posted by fry@google.com on 2011-03-24 at 06:08 PM


Christian, can you comment on this? I figure either it's already happened or it won't happen, as release 9 is on its way out the door now...

Original comment posted by fry@google.com on 2011-03-24 at 06:08 PM


Christian, can you comment on this? I figure either it's already happened or it won't happen, as release 9 is on its way out the door now...

@gissuebot

This comment has been minimized.

Show comment
Hide comment
@gissuebot

gissuebot Oct 31, 2014

Original comment posted by alexandre.ardhuin on 2011-03-24 at 06:16 PM


guava-gwt does not appear in any sub-folder of http://repo1.maven.org/maven2/com/google/guava/
What groupId/artifactId/version/classifier did you use ?

Original comment posted by alexandre.ardhuin on 2011-03-24 at 06:16 PM


guava-gwt does not appear in any sub-folder of http://repo1.maven.org/maven2/com/google/guava/
What groupId/artifactId/version/classifier did you use ?

@gissuebot

This comment has been minimized.

Show comment
Hide comment
@gissuebot

gissuebot Oct 31, 2014

Original comment posted by cgdecker on 2011-03-24 at 06:27 PM


I think at this point it would be fine if we could get this for r09 instead of r08. The main thing that's wanted here is the GWT jar in maven central and a way to ensure that happens for each release going forward.

Original comment posted by cgdecker on 2011-03-24 at 06:27 PM


I think at this point it would be fine if we could get this for r09 instead of r08. The main thing that's wanted here is the GWT jar in maven central and a way to ensure that happens for each release going forward.

@gissuebot

This comment has been minimized.

Show comment
Hide comment
@gissuebot

gissuebot Oct 31, 2014

Original comment posted by fry@google.com on 2011-03-24 at 06:32 PM


(No comment entered for this change.)


Status: Accepted
Labels: -Milestone-Release08, Milestone-Release09

Original comment posted by fry@google.com on 2011-03-24 at 06:32 PM


(No comment entered for this change.)


Status: Accepted
Labels: -Milestone-Release08, Milestone-Release09

@gissuebot

This comment has been minimized.

Show comment
Hide comment
@gissuebot

gissuebot Oct 31, 2014

Original comment posted by cgruber@google.com on 2011-03-24 at 09:50 PM


<sigh> Ok, if we're about to drop r09, then I'll fix it in trunk so we can release it all properly at the same time in the same process.

Original comment posted by cgruber@google.com on 2011-03-24 at 09:50 PM


<sigh> Ok, if we're about to drop r09, then I'll fix it in trunk so we can release it all properly at the same time in the same process.

@gissuebot

This comment has been minimized.

Show comment
Hide comment
@gissuebot

gissuebot Oct 31, 2014

Original comment posted by cgruber@google.com on 2011-03-24 at 09:52 PM


(No comment entered for this change.)


Labels: Priority-High, OpSys-All

Original comment posted by cgruber@google.com on 2011-03-24 at 09:52 PM


(No comment entered for this change.)


Labels: Priority-High, OpSys-All

@gissuebot

This comment has been minimized.

Show comment
Hide comment
@gissuebot

gissuebot Oct 31, 2014

Original comment posted by kevinb@google.com on 2011-04-08 at 01:15 AM


(No comment entered for this change.)


Labels: -Milestone-Release09, Milestone-Release10

Original comment posted by kevinb@google.com on 2011-04-08 at 01:15 AM


(No comment entered for this change.)


Labels: -Milestone-Release09, Milestone-Release10

@gissuebot

This comment has been minimized.

Show comment
Hide comment
@gissuebot

gissuebot Oct 31, 2014

Original comment posted by christoph.widulle on 2011-05-05 at 11:43 AM


Any news on this ?

Original comment posted by christoph.widulle on 2011-05-05 at 11:43 AM


Any news on this ?

@gissuebot

This comment has been minimized.

Show comment
Hide comment
@gissuebot

gissuebot Oct 31, 2014

Original comment posted by cgruber@google.com on 2011-05-05 at 12:20 PM


We're re-organizing the build system and it should all be there in the next couple of weeks.

Can you help out by giving us a sense of HOW you use the gwt artifact? At present, do you use the ant-built downloadable one as-is? And do you use it via the maven GWT plugins, or how does it fit into your lifecycle?

Christian.

Original comment posted by cgruber@google.com on 2011-05-05 at 12:20 PM


We're re-organizing the build system and it should all be there in the next couple of weeks.

Can you help out by giving us a sense of HOW you use the gwt artifact? At present, do you use the ant-built downloadable one as-is? And do you use it via the maven GWT plugins, or how does it fit into your lifecycle?

Christian.

@gissuebot

This comment has been minimized.

Show comment
Hide comment
@gissuebot

gissuebot Oct 31, 2014

Original comment posted by christianedwardgruber on 2011-05-05 at 12:21 PM


We're re-working the build system. It should be in within the next couple of weeks. Also, can you help describe how you use this artifact? Using what plugins to consume it, etc.?

Original comment posted by christianedwardgruber on 2011-05-05 at 12:21 PM


We're re-working the build system. It should be in within the next couple of weeks. Also, can you help describe how you use this artifact? Using what plugins to consume it, etc.?

@gissuebot

This comment has been minimized.

Show comment
Hide comment
@gissuebot

gissuebot Oct 31, 2014

Original comment posted by cgruber@google.com on 2011-05-05 at 12:26 PM


Heh. Forgot this wouldn't post to the bug. :)

Original comment posted by cgruber@google.com on 2011-05-05 at 12:26 PM


Heh. Forgot this wouldn't post to the bug. :)

@gissuebot

This comment has been minimized.

Show comment
Hide comment
@gissuebot

gissuebot Oct 31, 2014

Original comment posted by t.broyer on 2011-05-05 at 12:38 PM


We have an internal Artifactory Maven repo, so I simply downloaded the bundle from the Downloads page and deployed the guava-rXX-gwt.jar in the repository.
I deployed it with the same groupId and artifactId as Guava, using <classifier>gwt</classifier> to include it in our GWT modules; i.e.

  <dependency>
    <groupId>com.google.guava</groupId>
    <artifactId>guava</artifact>
    <version>${guava.version}</version>
  </dependency>
  <dependency>
    <groupId>com.google.guava</groupId>
    <artifactId>guava</artifact>
    <version>${guava.version}</version>
    <classifier>gwt</classifier>
  </dependency>

I believe however that the *-gwt.jar should be done differently, using GWT's <super-source> to "redefine" the implementations when GWT-specific code is needed. GWT isn't terribly well integrated with Maven (or is it the other way around?), but what worked well for us (what we use for our own modules) is to simply use the classifier=sources dependency, and bundle the GWT-specific implementations as <super-source> inside it.

FYI, we used both the gwt-maven-plugin and maven-antrun-plugin to launch the GWT compiler. We only do launch the compiler from Maven; we launch GWT's DevMode from within Eclipse.

Do not hesitate to ask if you need to know more.

Original comment posted by t.broyer on 2011-05-05 at 12:38 PM


We have an internal Artifactory Maven repo, so I simply downloaded the bundle from the Downloads page and deployed the guava-rXX-gwt.jar in the repository.
I deployed it with the same groupId and artifactId as Guava, using <classifier>gwt</classifier> to include it in our GWT modules; i.e.

  <dependency>
    <groupId>com.google.guava</groupId>
    <artifactId>guava</artifact>
    <version>${guava.version}</version>
  </dependency>
  <dependency>
    <groupId>com.google.guava</groupId>
    <artifactId>guava</artifact>
    <version>${guava.version}</version>
    <classifier>gwt</classifier>
  </dependency>

I believe however that the *-gwt.jar should be done differently, using GWT's <super-source> to "redefine" the implementations when GWT-specific code is needed. GWT isn't terribly well integrated with Maven (or is it the other way around?), but what worked well for us (what we use for our own modules) is to simply use the classifier=sources dependency, and bundle the GWT-specific implementations as <super-source> inside it.

FYI, we used both the gwt-maven-plugin and maven-antrun-plugin to launch the GWT compiler. We only do launch the compiler from Maven; we launch GWT's DevMode from within Eclipse.

Do not hesitate to ask if you need to know more.

@gissuebot

This comment has been minimized.

Show comment
Hide comment
@gissuebot

gissuebot Oct 31, 2014

Original comment posted by diaz.salvador on 2011-05-09 at 12:39 PM


@cgruber: responses inline:

Can you help out by giving us a sense of HOW you use the gwt artifact?
In short, we have 2 deps in our pom (just like t.broyer)

At present, do you use the ant-built downloadable one as-is?
Yes, but the gwt artifact by itself is not useful, the normal artifact is also required (see t.broyer comments about packaging of guava-gwt jar)

And do you use it via the maven GWT plugins, or how does it fit into your lifecycle?
We use the maven-gwt-plugin to compile GWT client-side code and Google Eclipse Plugin to launch GWT's DevMode

I'll be watching this bug if you need any further comment, but for now it would be enough to deploy the r09 GWT artifact as-is to maven central.

Thanks

Original comment posted by diaz.salvador on 2011-05-09 at 12:39 PM


@cgruber: responses inline:

Can you help out by giving us a sense of HOW you use the gwt artifact?
In short, we have 2 deps in our pom (just like t.broyer)

At present, do you use the ant-built downloadable one as-is?
Yes, but the gwt artifact by itself is not useful, the normal artifact is also required (see t.broyer comments about packaging of guava-gwt jar)

And do you use it via the maven GWT plugins, or how does it fit into your lifecycle?
We use the maven-gwt-plugin to compile GWT client-side code and Google Eclipse Plugin to launch GWT's DevMode

I'll be watching this bug if you need any further comment, but for now it would be enough to deploy the r09 GWT artifact as-is to maven central.

Thanks

@gissuebot

This comment has been minimized.

Show comment
Hide comment
@gissuebot

gissuebot Oct 31, 2014

Original comment posted by hanriseldon on 2011-06-09 at 08:59 AM


Hi, any news on this? The guava-gwt artifacts are still not present in maven central.
Thanks.

Original comment posted by hanriseldon on 2011-06-09 at 08:59 AM


Hi, any news on this? The guava-gwt artifacts are still not present in maven central.
Thanks.

@gissuebot

This comment has been minimized.

Show comment
Hide comment
@gissuebot

gissuebot Oct 31, 2014

Original comment posted by kevinb@google.com on 2011-07-13 at 06:18 PM


(No comment entered for this change.)


Status: Triaged

Original comment posted by kevinb@google.com on 2011-07-13 at 06:18 PM


(No comment entered for this change.)


Status: Triaged

@gissuebot

This comment has been minimized.

Show comment
Hide comment
@gissuebot

gissuebot Oct 31, 2014

Original comment posted by kevinb@google.com on 2011-07-16 at 08:32 PM


(No comment entered for this change.)


Status: Accepted

Original comment posted by kevinb@google.com on 2011-07-16 at 08:32 PM


(No comment entered for this change.)


Status: Accepted

@gissuebot

This comment has been minimized.

Show comment
Hide comment
@gissuebot

gissuebot Oct 31, 2014

Original comment posted by kelseyfrancis on 2011-08-02 at 11:27 AM


Any movement on this? We have a GWT library that we'd like to release to Maven Central, but can't because it depends on the guava-gwt artifacts (which aren't yet in Central).

Original comment posted by kelseyfrancis on 2011-08-02 at 11:27 AM


Any movement on this? We have a GWT library that we'd like to release to Maven Central, but can't because it depends on the guava-gwt artifacts (which aren't yet in Central).

@gissuebot

This comment has been minimized.

Show comment
Hide comment
@gissuebot

gissuebot Oct 31, 2014

Original comment posted by kevinb@google.com on 2011-08-03 at 03:10 AM


We're treating it as a release blocker this time.

Original comment posted by kevinb@google.com on 2011-08-03 at 03:10 AM


We're treating it as a release blocker this time.

@gissuebot

This comment has been minimized.

Show comment
Hide comment
@gissuebot

gissuebot Oct 31, 2014

Original comment posted by chris.shellenbarger on 2011-08-15 at 12:43 PM


What's keeping this from being released to Maven Central? The artifact has already been created, which is typically the hard part. Do you guys need help generating a pom.xml for it? If there's anything I can do to help get this artifact into Maven Central, please let me know.

Original comment posted by chris.shellenbarger on 2011-08-15 at 12:43 PM


What's keeping this from being released to Maven Central? The artifact has already been created, which is typically the hard part. Do you guys need help generating a pom.xml for it? If there's anything I can do to help get this artifact into Maven Central, please let me know.

@gissuebot

This comment has been minimized.

Show comment
Hide comment
@gissuebot

gissuebot Oct 31, 2014

Original comment posted by sowdri on 2011-08-21 at 12:13 PM


Would be much appreciated, it we could get this on central repo!

Original comment posted by sowdri on 2011-08-21 at 12:13 PM


Would be much appreciated, it we could get this on central repo!

@gissuebot

This comment has been minimized.

Show comment
Hide comment
@gissuebot

gissuebot Oct 31, 2014

Original comment posted by rafalwicha on 2011-08-31 at 01:13 PM


Just can't wait for this...

Original comment posted by rafalwicha on 2011-08-31 at 01:13 PM


Just can't wait for this...

@gissuebot

This comment has been minimized.

Show comment
Hide comment
@gissuebot

gissuebot Oct 31, 2014

Original comment posted by yrfselrahc on 2011-09-06 at 05:30 PM


These will be pushed when we push the release candidate.


Status: Fixed

Original comment posted by yrfselrahc on 2011-09-06 at 05:30 PM


These will be pushed when we push the release candidate.


Status: Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment