AbstractFutureTest adding clinit test

[MarcoLe3]

Hi

I wanted to try and dip my toe in the water. I saw a TODO comment about adding a clinit test for AbstractFuture class and was wondering if I can add a test case inside AbstractFutureTest.

[cpovirk]

I almost made the mistake of giving it a clinit a couple weeks ago, so that's probably a good test to have.

I recently freshened up https://github.com/google/guava/blob/master/CONTRIBUTING.md. It's still not anything like exhaustive, but it may be of some help.

[MarcoLe3]

Oh cool, I forked the repo and trying to go over the CONTRIBUTING.md before sending a pull request. I may have not noticed it while going through the repo, but is there a naming convention, style sheet or comment styling for this repo?

[MarcoLe3]

I found the style sheet

[MarcoLe3]

Hey, I was thinking of trying to read the bytes from the class with getResourceAsStream and use regex to find the word ( assuming external bytecode libraries are not allowed ).

[cpovirk]

The ideal is probably to use java.lang.classfile. We can arrange for the test not to be run under older Java versions.

[MarcoLe3]

I think I got the test case ready:

I imported with some existing packages and from JDK 25:

import com.google.common.io.ByteStreams;
import java.lang.classfile.ClassFile;
import java.lang.classfile.ClassModel;
import java.lang.classfile.MethodModel;

References

I used this link for reference for the test case:
https://docs.oracle.com/en/java/javase/23/docs/api/java.base/java/lang/classfile/package-summary.html

Protentional Solution

What the test case does is gets the path of abstractFuture path and uses InputStream getResourceAsStream() to get the stream and convert in toByteArray() from ByteStream. which is then used for java.lang.classfile.ClassModel with ClassFile to parse the bytes and try to find the string value of clinit.

I test ran it and got error prone blocked (expected) . Im assuming pom.xml will be updated in the future with extending it to JDK 25.

Should I wait for JDK 25 before sending a draft?

[cpovirk]

You can use @SuppressWarnings("Java8ApiChecker") there for Error Prone.

Then, if you aren't already getting JDK 25 at runtime, you might be able to get it by passing Maven -Dsurefire.toolchain.version=25.

[MarcoLe3]

Hi thank you for the advice with @SuppressWarnings("Java8ApiChecker"). It worked great :)